Open karimifard opened 1 year ago
EDIT: merged into main issue description.
Btw, before starting on all this it would be better to merge this PR https://github.com/GEOSX/GEOSX/pull/1925
@CusiniM Step 3 should be merged with step 2, since it has a direct impact on the computation of the stencil weights.
Hmm, I'm not 100% sure because we're reaching a point where the way we read the VTK is really decoupled from what we do with the digested data. Not to say that both ways are independent, nor that both ways are equally "easy", but depending on the resources and the priorities, we may want to willingly split those tasks.
@CusiniM Step 3 should be merged with step 2, since it has a direct impact on the computation of the stencil weights.
Hmm, I'm not 100% sure because we're reaching a point where the way we read the VTK is really decoupled from what we do with the digested data. Not to say that both ways are independent, nor that both ways are equally "easy", but depending on the resources and the priorities, we may want to willingly split those tasks.
ahah, I have modified my comment after Nicola's one so 2 and 3 are not the same thing anymore and I have already merged my origin point 2 and 3 into a single one.
When you're using the step, it implicitly means that there's an order. Is it what you mean? To which extent is this the case?
When you're using the step, it implicitly means that there's an order. Is it what you mean? To which extent is this the case?
I have deleted nicola's comment to avoid confusion.
Yeah, I wrote it with the idea of doing these things in sequence. IMO the only step that is kind of independent is the vtk upgrade which, as you said, could be done in parallel and kind of live its own life.
We may also need a backup plan for highly distorted elements.
The discretization must provide accurate two-point flux approximation for PEBI and orthogonal grids. Provide approximation for mesh elements with nonplanar faces. Remain compatible with existing explicit and embedded discrete fracture representation. Approximate use of full tensor permeability for TPFA.
List of features/capabilities:
MPFA Cleaning:
Inputs (1/2):
Computational geometry tools:
Discretization TPFA
Inputs (2/2):
vtk
input file format to better fit fracture needs (using multi-block or partitioned datasets)? @TotoGazImport of TPFA connectivities. (long term objective)