GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Simplify definition of regions in the XML #2223

Open jeannepellerin opened 1 year ago

jeannepellerin commented 1 year ago

What is the requested feature? As a user, I want to define easily regions from their name in the subsurface model.

A non exhaustive list of subitems are:

Is your request related to a specific problem? The XML file is very complex to write and there is no check of its validity. GEOSX might crash without notice and no error message.

Describe the solution you'd like Check of validity of the XML Clear error messages to the user Replace entries that have a meaning for the developers by entries that have a meaning for the users to define Regions

AntoineMazuyer commented 1 year ago

Great suggestion.

Using the VTU/VTK file there is unfortunately no way to associate an attribute id with a name... except using VTM structure BUT in my opinion, it will add complexity for users to build the mesh (need to respect a certain hierarchy, naming convention etc...).

One solution could be to provide a map attribute id <--> name that can be either communicate to geosx through an external file map.txt or in the vtu file (adding a new XML tag)

untereiner commented 1 year ago

IHMO To manage meaningful regions over representations a data format more Reservoir oriented like RESQML (#2109) would be more appropriate.

untereiner commented 1 year ago

If I can summarize (do not hesitate to correct me):