GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
210 stars 84 forks source link

Fix inconsistencies between serial and parallel conforming fracs run + add new output fields. #3065

Closed CusiniM closed 5 months ago

CusiniM commented 6 months ago

In this PR:

https://github.com/GEOS-DEV/integratedTests/pull/115

CusiniM commented 6 months ago

@jhuang2601 You should be able to test this branch.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 1.53846% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 53.23%. Comparing base (92e12f1) to head (393ffd7).

Files Patch % Lines
src/coreComponents/mesh/FaceElementSubRegion.cpp 0.00% 53 Missing :warning:
...sSolvers/contact/SolidMechanicsLagrangeContact.cpp 0.00% 37 Missing :warning:
...rc/coreComponents/mesh/SurfaceElementSubRegion.cpp 0.00% 12 Missing :warning:
...rc/coreComponents/mesh/SurfaceElementSubRegion.hpp 0.00% 7 Missing :warning:
src/coreComponents/mesh/MeshFields.hpp 0.00% 4 Missing :warning:
...olvers/contact/SolidMechanicsEmbeddedFractures.cpp 0.00% 3 Missing :warning:
...rc/coreComponents/mainInterface/ProblemManager.cpp 50.00% 2 Missing :warning:
...ysicsSolvers/contact/SolidMechanicsEFEMKernels.hpp 0.00% 2 Missing :warning:
.../fluidFlow/proppantTransport/ProppantTransport.cpp 0.00% 2 Missing :warning:
src/coreComponents/mesh/SurfaceElementRegion.cpp 0.00% 1 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3065 +/- ## =========================================== - Coverage 53.27% 53.23% -0.05% =========================================== Files 989 989 Lines 83504 83586 +82 =========================================== + Hits 44490 44493 +3 - Misses 39014 39093 +79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CusiniM commented 6 months ago

@TotoGaz I think we can add in this PR the check that @matteofrigo5 pointed out that is necessary to do on the normal vectors for the external import to work.

CusiniM commented 6 months ago

@TotoGaz I think we can add in this PR the check that @matteofrigo5 pointed out that is necessary to do on the normal vectors for the external import to work.

Done!

@jhuang2601 you should be able to test again the external mesh cases.