GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
210 stars 84 forks source link

Refactoring flow `StackVariables` to use `DerivOffset` #3085

Open jafranc opened 5 months ago

jafranc commented 5 months ago

As it is used in isothermalCompositionalMultiphaseFVMKernel or MultifluidBase, derivative offset helps readability and would made extension easier.

The refactoring though left out for now

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 53.25%. Comparing base (65064b0) to head (2147533).

Files Patch % Lines
...ls/SinglePhasePoromechanicsConformingFractures.hpp 0.00% 2 Missing :warning:
...nels/SinglePhasePoromechanicsEmbeddedFractures.hpp 0.00% 2 Missing :warning:
...malSinglePhasePoromechanicsConformingFractures.hpp 0.00% 1 Missing :warning:
...ermalSinglePhasePoromechanicsEmbeddedFractures.hpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3085 +/- ## ======================================== Coverage 53.25% 53.25% ======================================== Files 989 989 Lines 83542 83543 +1 ======================================== + Hits 44493 44494 +1 Misses 39049 39049 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.