GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
210 stars 84 forks source link

Stabilized Fixed-Stress #3092

Closed ryar9534 closed 5 months ago

ryar9534 commented 5 months ago

Activates the option for pressure stabilization in fixed-stress, multiphase poromechanics.

Some items in, for example, MultiphasePoromechanics.cpp could be moved to the base poromechanics solver class once single-phase stabilization is implemented, which I propose to do in a follow-up PR (though if it is preferred to do it here, I am happy to do that as well).

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 53.22%. Comparing base (a7c0d02) to head (cf0db53).

Files Patch % Lines
...csSolvers/multiphysics/MultiphasePoromechanics.cpp 0.00% 7 Missing :warning:
...sSolvers/fluidFlow/CompositionalMultiphaseBase.cpp 0.00% 3 Missing :warning:
...onents/physicsSolvers/fluidFlow/FlowSolverBase.cpp 50.00% 2 Missing :warning:
...ysics/CompositionalMultiphaseReservoirAndWells.hpp 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3092 +/- ## =========================================== - Coverage 53.23% 53.22% -0.01% =========================================== Files 989 989 Lines 83586 83600 +14 =========================================== + Hits 44493 44494 +1 - Misses 39093 39106 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paveltomin commented 5 months ago

now you don't have a test covering the new feature?

jhuang2601 commented 5 months ago

If pressure stabilization is enabled by default, rebaseline is still needed for certain smoke tests with sequential coupling.

ryar9534 commented 5 months ago

I will add new tests when doing the single phase stabilization PR, as the current test using stabilization isnt super meaningful right now anyway. Stabilization is not enabled by default, so it shouldnt affect any existing tests. Nicola and I ran the integrated tests and it only failed the one staircase example with sequential where I had added stabilization @paveltomin @jhuang2601