Closed ryar9534 closed 5 months ago
Attention: Patch coverage is 12.50000%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 53.22%. Comparing base (
a7c0d02
) to head (cf0db53
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
now you don't have a test covering the new feature?
If pressure stabilization is enabled by default, rebaseline is still needed for certain smoke tests with sequential coupling.
I will add new tests when doing the single phase stabilization PR, as the current test using stabilization isnt super meaningful right now anyway. Stabilization is not enabled by default, so it shouldnt affect any existing tests. Nicola and I ran the integrated tests and it only failed the one staircase example with sequential where I had added stabilization @paveltomin @jhuang2601
Activates the option for pressure stabilization in fixed-stress, multiphase poromechanics.
Some items in, for example, MultiphasePoromechanics.cpp could be moved to the base poromechanics solver class once single-phase stabilization is implemented, which I propose to do in a follow-up PR (though if it is preferred to do it here, I am happy to do that as well).