search

GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
210 stars 84 forks source link

Clean up catalogName a bit #3110

Closed paveltomin closed 4 months ago

paveltomin commented 5 months ago

catalog name related piece from https://github.com/GEOS-DEV/GEOS/pull/3021/

rrsettgast commented 5 months ago

@paveltomin Did you search the whole codebase? There may be more places

paveltomin commented 5 months ago

@paveltomin Did you search the whole codebase? There may be more places

i looked through yes but would not guarantee i paid full attention mostly looked into solvers part

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 53.72%. Comparing base (7e72289) to head (573caf0).

Files Patch % Lines
...ysics/CompositionalMultiphaseReservoirAndWells.cpp 83.33% 1 Missing :warning:
...csSolvers/multiphysics/MultiphasePoromechanics.cpp 0.00% 1 Missing :warning:
...sSolvers/multiphysics/SinglePhasePoromechanics.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3110 +/- ## ======================================== Coverage 53.72% 53.72% ======================================== Files 994 994 Lines 84687 84676 -11 ======================================== - Hits 45499 45495 -4 + Misses 39188 39181 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.