search

GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Fix updateConfiguration #3113

Closed paveltomin closed 1 month ago

paveltomin commented 2 months ago

Added general version updateConfiguration and few related functions into CoupledSolver and realized that SinglePhasePoromechanicsEmbeddedFractures was missing updateConfiguration completely. Now all corresponding cases fail in ATS and one (SlipPermeability_pEDFM_smoke) can not finish, allowed more newton iteration there so it can converge.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 53.69%. Comparing base (19c3850) to head (a7eb944).

Files Patch % Lines
...ents/physicsSolvers/multiphysics/CoupledSolver.hpp 0.00% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3113 +/- ## =========================================== - Coverage 53.70% 53.69% -0.01% =========================================== Files 1010 1010 Lines 85639 85649 +10 =========================================== Hits 45991 45991 - Misses 39648 39658 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jhuang2601 commented 1 month ago

Expected failures and rebaseline is needed

=======================
Test failures
=======================
ExponentialDecayPermeability_edfm_smoke_01
ExponentialDecayPermeability_edfm_smoke_04
PoroElastic_efem-edfm_pressurizedFrac_smoke_01
PoroElastic_efem-edfm_pressurizedFrac_smoke_04
SlipPermeability_pEDFM_smoke_01
SlipPermeability_pEDFM_smoke_04
ThermoPoroElastic_efem-edfm_verticalFrac_smoke_01
ThermoPoroElastic_efem-edfm_verticalFrac_smoke_04
WillisRichardsPermeability_efem-edfm_smoke_01
WillisRichardsPermeability_efem-edfm_smoke_04
=======================
Overall status: FAILED
=======================
IntegratedTests failed. Rebaseline is required.