GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Activate fluid models #3123

Closed dkachuma closed 1 month ago

dkachuma commented 1 month ago

This PR activates some fluid models in MultiFluidSelector.hpp only for CPU builds. The issue is that when activated for CUDA builds, these extra models cause compilation failures for some of the GHA pipelines. These are therefore currently being activated only for non-device builds.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.70%. Comparing base (0f53ecd) to head (9449600).

Files Patch % Lines
...onents/constitutive/fluid/multifluid/PVTDriver.cpp 50.00% 1 Missing :warning:
...ompositional/models/NegativeTwoPhaseFlashModel.hpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3123 +/- ## ======================================== Coverage 53.70% 53.70% ======================================== Files 1010 1010 Lines 85637 85639 +2 ======================================== + Hits 45990 45993 +3 + Misses 39647 39646 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.