search

GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Compilation failure on pangea-3 if ENABLE_CUDA is OFF #3129

Closed Algiane closed 3 weeks ago

Algiane commented 1 month ago

Configuring and compiling geos with the TOTAL/pangea3-gcc8.4.1-openmpi-4.1.2.cmake host-config file and the -DENABLE_CUDA=OFF option fails.

This PR fixes inconsistencies in the adding of the NvToolExt component: the value of the ENABLE_CUDA variable is tested and NvToolExt is not added if ENABLE_CUDA is OFF (previously it was partially added, leading to compilation errors).

Associated to the PR 264 of TPLs, it allows to easily build Geos without Cuda on Pangea.

Linked to:

Resolves:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.69%. Comparing base (bd75ec8) to head (d112c66).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3129 +/- ## ======================================== Coverage 53.69% 53.69% ======================================== Files 1010 1010 Lines 85663 85663 ======================================== Hits 45998 45998 Misses 39665 39665 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Algiane commented 1 month ago

@TotoGaz : everything should be ok now. The coverage is marked as failed due to an indirect change (this PR doesn't touch the code at all).

Best