GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Modified label used to run cuda jobs #3131

Closed CusiniM closed 1 month ago

CusiniM commented 1 month ago

I think it's time for us to do this.

I have left the old label for now. We can delete it once we merge this.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.57%. Comparing base (07d1ce3) to head (486f281).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3131 +/- ## ======================================== Coverage 53.57% 53.57% ======================================== Files 1003 1003 Lines 85297 85297 ======================================== Hits 45695 45695 Misses 39602 39602 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CusiniM commented 1 month ago

do we prefer CUDA jobs or CUDA builds ?

CusiniM commented 1 month ago

You can change the name of the label through the web ui when you merge this.

yeah but there s 2 labels now. I can just ditch the old one.

ryar9534 commented 1 month ago

do we prefer CUDA jobs or CUDA builds ?

I personally prefer CUDA builds

TotoGaz commented 1 month ago

You can change the name of the label through the web ui when you merge this.

yeah but there s 2 labels now. I can just ditch the old one.

Behind the scenes, I guess that labels have an GitHub internal identifier. Changing the name of the label will automatically spread to all the PRs (past, present and future) with no further action required. Up to you.

CusiniM commented 1 month ago

You can change the name of the label through the web ui when you merge this.

yeah but there s 2 labels now. I can just ditch the old one.

Behind the scenes, I guess that labels have an GitHub internal identifier. Changing the name of the label will automatically spread to all the PRs (past, present and future) with no further action required. Up to you.

yes, if we care about past prs yes. For the present ones it would actually be good to force ppl to make the change manually so that they notice it.