Closed paveltomin closed 3 weeks ago
Attention: Patch coverage is 7.24638%
with 64 lines
in your changes missing coverage. Please review.
Project coverage is 53.76%. Comparing base (
4de1337
) to head (798f833
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good to me. My only question is: would we want to keep this as a "feature"? That is the user deliberately chooses different non-linear parameters for the different solvers?
this logic only applies for fully coupled solvers, in this case different params does not make much sense
for sequential it is not going to sync anything and there is flexibility to choose different settings
Some solvers logic depends on the number of Newton iterations.
synchronizeNonlinearSolverParameters
was supposed to take care of that but it was not placed correctly. In particular, the issue is that currently number of iterations for coupled solvers does not propagate down to subsolvers. This PR tries to fix that. Also add some debug info output for time step selection.