Closed jafranc closed 1 week ago
@jafranc can you explain a little bit what was the issue and how you got it fixed?
@jafranc can you explain a little bit what was the issue and how you got it fixed?
I updated the description above. I am reporting Oleg experience and fix there.
Attention: Patch coverage is 0%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 55.88%. Comparing base (
399ec9d
) to head (1d488d8
).
Files | Patch % | Lines |
---|---|---|
src/coreComponents/events/PeriodicEvent.cpp | 0.00% | 13 Missing :warning: |
src/coreComponents/functions/FunctionBase.cpp | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fix #3146 - Error in stat reduction for Function triggered
PeriodicEvent
Using such a XML block as
Attempting to use
function
attribute ofPeriodic
event and its related attributestat
to trigger periodic event if min (0 is for min, 1 is for average, 2 is for max) of thefunction
is abovethreshold
was not working properly:stat=2
, i.e. for maximumindeed,
FunctionBase.cpp
was comparing min to max.Moreover, for partitions not intersecting (
N=0
in FunctionBase.cpp) withobject
the workflow was returning1e10
for min and-1e10
for max in parallel reductions.