GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Some random things #3152

Closed paveltomin closed 2 weeks ago

paveltomin commented 1 month ago
  1. Print percentage of simulation complete:
    ------------------- TIMESTEP START -------------------
    - Time:       11h31m46s (41506.95883192398 s) out of 12h00m00s (43200 s) (96%)
    - Delta Time: 00h01m40s (100 s)
    - Cycle:      2167
    ------------------------------------------------------
  2. Make minScalingFactor modifiable from input.
  3. Some cosmetic things in output.
  4. Changes the format for negative time in units::TimeFormatInfo so that this is printed as (see #3155):
    - Time:       -(11h31m46s) (-41506.95883192398 s) (96%)
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.78%. Comparing base (d2225bd) to head (62f4d28).

Files Patch % Lines
...csSolvers/fluidFlow/CompositionalMultiphaseFVM.cpp 0.00% 6 Missing :warning:
src/coreComponents/events/EventManager.cpp 91.30% 2 Missing :warning:
...nents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3152 +/- ## =========================================== + Coverage 53.76% 53.78% +0.02% =========================================== Files 1016 1016 Lines 85781 85824 +43 =========================================== + Hits 46122 46164 +42 - Misses 39659 39660 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MelReyCG commented 3 weeks ago

Hi @paveltomin, Just to notify that I pushed, here is a simulated exemple:

------------------------- TIMESTEP START -------------------------
    - Time:       12y, 119d, 09h42m56s out of 15y, 308d, 09h35m20s (78% completed)
                  (389000000 s / 500000000 s)
    - Delta Time: 5d, 18h53m20s (500000 s)
    - Cycle:      792
--------------------------------------------------------------------

Don't hesitate to give feedback on this

paveltomin commented 3 weeks ago

Don't hesitate to give feedback on this

Looks good to me, thanks @dkachuma what do you think?

MelReyCG commented 3 weeks ago

Just suggestions in order to highlight the current timestep:

paveltomin commented 3 weeks ago

Just suggestions in order to highlight the current timestep:

  • should we use / instead of out of (it could be more easily seen)?
  • should we jump another line just before the out of?

/ is fine, and I would prefer less lines