Closed paveltomin closed 2 weeks ago
Attention: Patch coverage is 85.71429%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 53.78%. Comparing base (
d2225bd
) to head (62f4d28
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @paveltomin, Just to notify that I pushed, here is a simulated exemple:
------------------------- TIMESTEP START -------------------------
- Time: 12y, 119d, 09h42m56s out of 15y, 308d, 09h35m20s (78% completed)
(389000000 s / 500000000 s)
- Delta Time: 5d, 18h53m20s (500000 s)
- Cycle: 792
--------------------------------------------------------------------
Don't hesitate to give feedback on this
Don't hesitate to give feedback on this
Looks good to me, thanks @dkachuma what do you think?
Just suggestions in order to highlight the current timestep:
/
instead of out of
(it could be more easily seen)?out of
?Just suggestions in order to highlight the current timestep:
- should we use
/
instead ofout of
(it could be more easily seen)?- should we jump another line just before the
out of
?
/
is fine, and I would prefer less lines
minScalingFactor
modifiable from input.units::TimeFormatInfo
so that this is printed as (see #3155):