Closed dkachuma closed 2 weeks ago
Attention: Patch coverage is 28.04878%
with 118 lines
in your changes missing coverage. Please review.
Project coverage is 56.45%. Comparing base (
880d43c
) to head (c0a1a79
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR addresses one of the outstanding items from #2879. It adds xml changes to allow the user to specify some fluid parameters.
This is done generically for current (and future) fluid models. The
ModelParameters
class is added as a generic unspecified base class that contains specific model parameters for a specific model. If a fluid model requires additional parameters:ModelParameters
class should be extended to include the new parameters.registerParametersImpl
method allows these parameters to be registered on theCompositionalFluidModel
class.postProcessInputImpl
is a callback to instantiate/validate the parameters.createParameters
to create an instance of this extended class.This is done for the specific cases:
ConstantViscosity
: Specifies an array of constant viscosity for each phase.LohrenzBrayClarkViscosity
: Specifies the mixing rule to be used for phase viscosity. The component critical volume is currently only required for this model. So it is moved fromComponentProperties
.The standard compositional fluid model parameters are now owned by the
ComponentProperties
object.