GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Allow extra parameters for fluid models #3157

Closed dkachuma closed 2 weeks ago

dkachuma commented 1 month ago

This PR addresses one of the outstanding items from #2879. It adds xml changes to allow the user to specify some fluid parameters.

This is done generically for current (and future) fluid models. The ModelParameters class is added as a generic unspecified base class that contains specific model parameters for a specific model. If a fluid model requires additional parameters:

This is done for the specific cases:

The standard compositional fluid model parameters are now owned by the ComponentProperties object.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 28.04878% with 118 lines in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (880d43c) to head (c0a1a79).

Files Patch % Lines
...uid/compositional/CompositionalMultiphaseFluid.cpp 0.00% 43 Missing :warning:
...tifluid/compositional/models/ConstantViscosity.cpp 0.00% 25 Missing :warning:
...compositional/models/LohrenzBrayClarkViscosity.cpp 42.10% 22 Missing :warning:
...ultifluid/compositional/models/ModelParameters.hpp 30.00% 14 Missing :warning:
...uid/multifluid/compositional/models/PhaseModel.hpp 0.00% 6 Missing :warning:
...tifluid/compositional/models/ConstantViscosity.hpp 0.00% 3 Missing :warning:
...compositional/models/LohrenzBrayClarkViscosity.hpp 33.33% 2 Missing :warning:
...luid/multifluid/compositional/models/NullModel.hpp 0.00% 2 Missing :warning:
...ompositional/models/NegativeTwoPhaseFlashModel.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3157 +/- ## =========================================== - Coverage 56.49% 56.45% -0.04% =========================================== Files 1021 1022 +1 Lines 86339 86421 +82 =========================================== + Hits 48775 48792 +17 - Misses 37564 37629 +65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.