GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Fix bug when we take minTime < 0 in wave solvers #3158

Closed acitrain closed 1 month ago

acitrain commented 1 month ago

This PR fix a bug when we want to start a simulation with a negative minTime.

Such issue have been fixed in the past inside the acoustic solver but not propagate inside the other wave solvers, which is done inside this PR.

The main change is on the value of cycleNumber: -If minTime is positive, the value of cycleNumber is taken as it is computed in GEOS

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.55%. Comparing base (16bf8b5) to head (9e2fefd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3158 +/- ## =========================================== - Coverage 53.56% 53.55% -0.01% =========================================== Files 1003 1003 Lines 85307 85295 -12 =========================================== - Hits 45695 45683 -12 Misses 39612 39612 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.