Closed paveltomin closed 2 weeks ago
Attention: Patch coverage is 46.66667%
with 48 lines
in your changes missing coverage. Please review.
Project coverage is 56.41%. Comparing base (
02f04e3
) to head (db80fad
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We already have the composition change maxCompFractionChange
. Doesn't this indirectly cover the functionality provided by maxRelativeCompDensChange
?
We already have the composition change
maxCompFractionChange
. Doesn't this indirectly cover the functionality provided bymaxRelativeCompDensChange
?
If one density value is much smaller than another, maxCompFractionChange
is not going to capture the changes i think, that's why i tried to introduce that relative scaling
Two experimental options:
targetRelativeCompDensChange
: use relative change of component density to select time step sizemaxRelativeCompDensChange
: chop component density Newton update exciding maximum relative change Both are inactive by defaultShould go after https://github.com/GEOS-DEV/GEOS/pull/3138 (merged) and https://github.com/GEOS-DEV/GEOS/pull/3152 (merged)
Was hoping it might help with SPE11a but no, still worth to keep for testing imho.