search

GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Small bug fix #3165

Closed paveltomin closed 2 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.40%. Comparing base (5e5a251) to head (181c4b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3165 +/- ## ======================================== Coverage 56.40% 56.40% ======================================== Files 1023 1023 Lines 86565 86566 +1 ======================================== + Hits 48829 48830 +1 Misses 37736 37736 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tjb-ltk commented 3 weeks ago

Good find.. the constructor initiated value to 1 and the wrong key name some how prevented it from being set to zero....... However in the fix, the setApplyDefaultValue should be 1, consistent with reservoir default . I would assume that this value should always be the same as reservoir...

paveltomin commented 3 weeks ago

Good find.. the constructor initiated value to 1 and the wrong key name some how prevented it from being set to zero....... However in the fix, the setApplyDefaultValue should be 1, consistent with reservoir default . I would assume that this value should always be the same as reservoir...

yes, you are right just fixed, thanks!

paveltomin commented 3 weeks ago

Rebaseline required due to appearance of useTotalMassEquation in well solver params. No real results change.