Closed dkachuma closed 1 day ago
Attention: Patch coverage is 83.85965%
with 46 lines
in your changes missing coverage. Please review.
Project coverage is 55.75%. Comparing base (
8ef428e
) to head (8fbfdae
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The purpose of this PR is to remove the equation of state template parameter from
CompositonalFluidModel
. The reason for this is to reduce the number of types listed in MultiFluidSelector.hpp. It also simplifies user input.Removing the EOS template parameter from
CompositonalFluidModel
cuts the number of types from 4 to 2. Instead of the EOS being implicitly determined by the object type, there is a user fieldequationsOfState
(similar toCompositonalFluidModelPVTPackage
) which determines the EOS to be used. The downside is that the EOS parameters have to be passed to the compute kernels. The selection is now done withif-else
statements (e.g. FugacityCalculator.hpp).