search

GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Decouple debug matrix output from logLevel #3181

Closed paveltomin closed 1 week ago

paveltomin commented 1 week ago

Small thing - introduce writeMatrix flag to separate debug matrix output from logLevel Logic is similar to old one: writeMatrix = 1 - print to screen writeMatrix >= 2 - print to file

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.69%. Comparing base (6139149) to head (dbfb9cf).

Files Patch % Lines
src/coreComponents/physicsSolvers/SolverBase.cpp 88.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3181 +/- ## ======================================== Coverage 55.68% 55.69% ======================================== Files 1032 1032 Lines 87740 87750 +10 ======================================== + Hits 48861 48871 +10 Misses 38879 38879 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paveltomin commented 1 week ago

Looks good! Just adding couple of ideas...

thanks, just implemented both