GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Coupling of IX to GEOS #3192

Open MichaelSekachev opened 6 days ago

rrsettgast commented 6 days ago

@MichaelSekachev Can you post your link command and the subsequent error on this PR?

MichaelSekachev commented 6 days ago

@MichaelSekachev Can you post your link command and the subsequent error on this PR?

@rrsettgast. Indeed, if I saw the command I might have spotted the issue. So how do I do that? Please find attached the full log of the make command... make -j 16 2>&1 | tee -a output-geos-make-rdhpc8-debug.txt output-geos-make-rdhpc8-debug.txt Here is also cmake cache file, which seem to list the correct files in _BLT_GRPC_LIBRARIES: CMakeCache.txt

rrsettgast commented 6 days ago

@MichaelSekachev

make VERBOSE=1
MichaelSekachev commented 6 days ago

@MichaelSekachev

make VERBOSE=1

Thanks. Indeed, it looks like the libraries are not linked against. No -lgrpc++ or anything else. Please see the attached log: output-geos-make-rdhpc8-debug-verbose.txt

rrsettgast commented 6 days ago

Do you know if cmake was used to build grpc?

MichaelSekachev commented 6 days ago

Do you know if cmake was used to build grpc?

I would say, yes. I built it using my branch in TPL: https://github.com/GEOS-DEV/thirdPartyLibs/compare/master...msek/ix-geos-coupling

rrsettgast commented 5 days ago

there should be a way to include the library using the cmake files generated by the build of gfrc. Are there some cmake files in the lib directory of the gfrc install?

MichaelSekachev commented 5 days ago

there should be a way to include the library using the cmake files generated by the build of gfrc. Are there some cmake files in the lib directory of the gfrc install?

I don't really know how CMake works. When grpc finishes installing it creates two folders lib and lib64` with the following contents: Screenshot 2024-06-28 221355

image
rrsettgast commented 2 days ago

hello @MichaelSekachev I added a commit as an example to import packages. I don't really recall the details of importing cmake targets. @wrtobin Do you recall the proper way to import cmake targets from the information shown above?

MichaelSekachev commented 1 day ago

hello @MichaelSekachev I added a commit as an example to import packages. I don't really recall the details of importing cmake targets. @wrtobin Do you recall the proper way to import cmake targets from the information shown above?

HI @rrsettgast . Thank you. So, the idea is to try to use find_package instead of find_and_register. Your commit seem to have a lot of unrelated changes. This is perhaps because my branch is based on a one year old version of the code. So, I need to create a FindGrpc.cmake file, right? Byt the way, I am currently on vacation and will be out of town for one week starting tomorrow. I will do things as I am able to. Thank you for all of your help.

rrsettgast commented 1 day ago

hello @MichaelSekachev I added a commit as an example to import packages. I don't really recall the details of importing cmake targets. @wrtobin Do you recall the proper way to import cmake targets from the information shown above?

HI @rrsettgast . Thank you. So, the idea is to try to use find_package instead of find_and_register. Your commit seem to have a lot of unrelated changes. This is perhaps because my branch is based on a one year old version of the code. So, I need to create a FindGrpc.cmake file, right? Byt the way, I am currently on vacation and will be out of town for one week starting tomorrow. I will do things as I am able to. Thank you for all of your help.

I see a bunch of *.cmake files in your tree. Those are the ones you want. So you are good. Can you put up a tarball with your *.cmake files?

untereiner commented 1 day ago

Hello @MichaelSekachev Here is one or just use find_package(gRPC CONFIG REQUIRED) as shown here