Open paveltomin opened 5 days ago
Attention: Patch coverage is 2.08333%
with 94 lines
in your changes missing coverage. Please review.
Project coverage is 55.71%. Comparing base (
94a0e86
) to head (d9b7330
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
is hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump ) essentially using aperture table?
is hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump ) essentially using aperture table?
yes
Main thing: replace
hydraulicAperture[k] = minimumHydraulicAperture[k] + aperture[k];
withhydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump );
for poromechanics with conforming fractures. At least this way there will be no negative aperture and no negative volume.Small things:
computeFractureStateStatistics
to see new segments slipped.logLevel>=2
.logLevel>=10
- display fracture state changes with debug information.deltaVolume
logic: assign it to 0 once applied into volume (to avoid double counting), update mass with updated volume. Those are important for fractures after poromechanics initialization that changes the volume of the fractures.