GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
203 stars 80 forks source link

Use aperture table in poromechanics with conforming fractures #3194

Open paveltomin opened 5 days ago

paveltomin commented 5 days ago

Main thing: replace hydraulicAperture[k] = minimumHydraulicAperture[k] + aperture[k]; with hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump ); for poromechanics with conforming fractures. At least this way there will be no negative aperture and no negative volume.

Small things:

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 2.08333% with 94 lines in your changes missing coverage. Please review.

Project coverage is 55.71%. Comparing base (94a0e86) to head (d9b7330).

Files Patch % Lines
...sSolvers/contact/SolidMechanicsLagrangeContact.cpp 0.00% 44 Missing :warning:
...cs/SinglePhasePoromechanicsConformingFractures.cpp 0.00% 17 Missing :warning:
...nents/physicsSolvers/contact/ContactSolverBase.cpp 0.00% 14 Missing :warning:
...hysicsSolvers/multiphysics/HydrofractureSolver.cpp 0.00% 12 Missing :warning:
...hysicsSolvers/contact/SolidMechanicsALMKernels.hpp 0.00% 2 Missing :warning:
...nents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp 50.00% 2 Missing :warning:
...anicsKernels/SinglePhasePoromechanicsFractures.hpp 0.00% 2 Missing :warning:
...rc/coreComponents/mesh/SurfaceElementSubRegion.hpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3194 +/- ## =========================================== - Coverage 55.75% 55.71% -0.04% =========================================== Files 1041 1041 Lines 88534 88579 +45 =========================================== - Hits 49358 49355 -3 - Misses 39176 39224 +48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Guotong-Ren commented 2 days ago

is hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump ) essentially using aperture table?

paveltomin commented 2 days ago

is hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump ) essentially using aperture table?

yes