search

GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
210 stars 84 forks source link

feat: enable CODEOWNERS #3205

Closed rrsettgast closed 2 months ago

rrsettgast commented 3 months ago

This PR adds the CODEOWNERS file which will be used for enforcing reviews by specific individuals (code owners) on specific subdirectories.

@castelletto1 @CusiniM @herve-gross @TotoGaz @paveltomin please look at the file and submit changes.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.75%. Comparing base (94a0e86) to head (618b2fb). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3205 +/- ## ======================================== Coverage 55.75% 55.75% ======================================== Files 1041 1041 Lines 88534 88534 ======================================== Hits 49358 49358 Misses 39176 39176 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paveltomin commented 2 months ago

@rrsettgast is it possible to disable that for drafts?

MelReyCG commented 2 months ago

@paveltomin isn't it already "silenced" for draft? I think we only see the codeowners on drafts, but don't actually send notifications.

paveltomin commented 2 months ago

@paveltomin isn't it already "silenced" for draft? I think we only see the codeowners on drafts, but don't actually send notifications.

I am not sure if it is silenced or not, sorry I just saw people getting added as reviewers for drafts and got confused if that will trigger notifications for them