Open CusiniM opened 3 months ago
Attention: Patch coverage is 18.44660%
with 84 lines
in your changes missing coverage. Please review.
Project coverage is 55.74%. Comparing base (
94a0e86
) to head (0f7b24d
). Report is 4 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There was an hardcoded preprocessor variiable that forced the computation of the degradation function for the
SpectralSplit
to only be valid for a linear dissipation function. This PR removes that ifdef and makes both options available.Because of the way the model is currently used I had to come up with a mixed solution. The selection is done statically for the phase field damage kernels but dynamically for the smallStrainUpdate. It's fairly easy to template the full damage model but I want to have a chat with @frankfeifan about the formulation and what degradation/dissipation functions combinations are actually valid.