Closed CusiniM closed 2 months ago
Attention: Patch coverage is 3.12500%
with 31 lines
in your changes missing coverage. Please review.
Project coverage is 55.73%. Comparing base (
94a0e86
) to head (92c1457
). Report is 5 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello @CusiniM I am wondering, are raja and chai direct dependencies of GEOS or are they transitive dependencies via lvarray ?
Hello @CusiniM I am wondering, are raja and chai direct dependencies of GEOS or are they transitive dependencies via lvarray ?
direct dependencies: https://github.com/GEOS-DEV/GEOS/blob/a3b438dd4e451a82c24923ebeb58791230a73800/src/coreComponents/common/GEOS_RAJA_Interface.hpp#L23
@cssherman can you approve this?
I am looking a bit more to the Lvarray dependencies:
Can lvarray live without raja ? In the negative case it would be cleaner that geos only depends on lvarray and let lvarray manage the raja dependency (version, public API for geos, etc.) Do you agree ?
RAJA is one of the few hard dependencies of LvArray.
https://github.com/GEOS-DEV/thirdPartyLibs/pull/273 https://github.com/GEOS-DEV/LvArray/pull/322
Updated tpls: