GEOS-DEV / GEOS

GEOS Simulation Framework
GNU Lesser General Public License v2.1
210 stars 84 forks source link

chore: update trilinos, hypre and fmt. #3214

Closed CusiniM closed 2 months ago

CusiniM commented 3 months ago

https://github.com/GEOS-DEV/thirdPartyLibs/pull/273 https://github.com/GEOS-DEV/LvArray/pull/322

Updated tpls:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 55.73%. Comparing base (94a0e86) to head (92c1457). Report is 5 commits behind head on develop.

Files Patch % Lines
...Strategies/MultiphasePoromechanicsReservoirFVM.hpp 0.00% 18 Missing :warning:
src/coreComponents/common/DataTypes.hpp 0.00% 1 Missing :warning:
src/coreComponents/dataRepository/DataContext.hpp 0.00% 1 Missing :warning:
...onents/linearAlgebra/interfaces/hypre/HypreMGR.hpp 0.00% 1 Missing :warning:
...hypre/mgrStrategies/CompositionalMultiphaseFVM.hpp 0.00% 1 Missing :warning:
...mgrStrategies/CompositionalMultiphaseHybridFVM.hpp 0.00% 1 Missing :warning:
...Strategies/CompositionalMultiphaseReservoirFVM.hpp 0.00% 1 Missing :warning:
...gies/CompositionalMultiphaseReservoirHybridFVM.hpp 0.00% 1 Missing :warning:
...es/hypre/mgrStrategies/MultiphasePoromechanics.hpp 0.00% 1 Missing :warning:
...es/SinglePhasePoromechanicsConformingFractures.hpp 0.00% 1 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3214 +/- ## =========================================== - Coverage 55.75% 55.73% -0.02% =========================================== Files 1041 1041 Lines 88534 88562 +28 =========================================== + Hits 49358 49362 +4 - Misses 39176 39200 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

untereiner commented 2 months ago

Hello @CusiniM I am wondering, are raja and chai direct dependencies of GEOS or are they transitive dependencies via lvarray ?

CusiniM commented 2 months ago

Hello @CusiniM I am wondering, are raja and chai direct dependencies of GEOS or are they transitive dependencies via lvarray ?

direct dependencies: https://github.com/GEOS-DEV/GEOS/blob/a3b438dd4e451a82c24923ebeb58791230a73800/src/coreComponents/common/GEOS_RAJA_Interface.hpp#L23

CusiniM commented 2 months ago

@cssherman can you approve this?

untereiner commented 2 months ago

I am looking a bit more to the Lvarray dependencies:

Can lvarray live without raja ? In the negative case it would be cleaner that geos only depends on lvarray and let lvarray manage the raja dependency (version, public API for geos, etc.) Do you agree ?

corbett5 commented 2 months ago

RAJA is one of the few hard dependencies of LvArray.