search

GEOS-DEV / LvArray

Portable HPC Containers (C++)
BSD 3-Clause "New" or "Revised" License
48 stars 10 forks source link

Add LVARRAY_ERROR_IF_PRINTF() macro to prinnt fancyer messages on errors #255

Closed XL64 closed 2 years ago

XL64 commented 2 years ago

Attempt to solve issue #254. Added new macro to use printf on device with clearer message. Still not perfect, we don't know were we are when the error is raised.

Now the dimensions are correctly printed: ERROR LOCATION: /work206/workrd/users/lacoste_x/remote_builds/GEOSX/src/coreComponents/LvArray/src/ArraySlice.hpp:295 Block: [3, 0, 0] Thread: [16, 0, 0] Controlling expression (should be false): index < 0 || index >= m_dims[ 0 ] MSG: Array Bounds Check Failed: index=8 m_dims[0]=8

XL64 commented 2 years ago

Ok thanks, I'll change the code. I was indeed wondering how we tested LVArray, thanks for the explanation i'll do so.

corbett5 commented 2 years ago

Any reason you closed this, it seems quite nice.

XL64 commented 2 years ago

It raised errors in geosx that i failed to fix. And i have no time at the moment to do it. You can reopen if you want.

Regards,

XL

Le mar. 7 juin 2022, 18:59, Ben Corbett @.***> a écrit :

Any reason you closed this, it seems quite nice.

— Reply to this email directly, view it on GitHub https://github.com/GEOSX/LvArray/pull/255#issuecomment-1148931613, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL44MTWSSLOKQSY6SLZJ23VN55X7ANCNFSM5RVPHDXQ . You are receiving this because you modified the open/close state.Message ID: @.***>