Throw exceptions instead of errors in stringToArray

GEOS-DEV / LvArray

Portable HPC Containers (C++)

BSD 3-Clause "New" or "Revised" License

47 stars 10 forks source link

Throw exceptions instead of errors in stringToArray #280

Closed MelReyCG closed 1 year ago

MelReyCG commented 1 year ago

This PR aims to:

Throw exceptions from LvArray::input::stringToArray() instead of errors. This will help to add context to these parsing errors by catching these exceptions, as a lot of parsing function & method propose to.
Detect when a token is missing before a '}'
Slightly reformulate some error messages and add one when a comma is placed just before the ending brace.

TotoGaz commented 1 year ago

@corbett5 @rrsettgast Can you put the appropriate protections in place such that

does not happen anymore? I'm upgrading LvArray as a submodule and I'm impacted by this premature merge.

rrsettgast commented 1 year ago

@corbett5 @rrsettgast Can you put the appropriate protections in place such that

does not happen anymore? I'm upgrading LvArray as a submodule and I'm impacted by this premature merge.

?? There we no limitations on who could merge a PR. They are in place now.

TotoGaz commented 1 year ago

I'm not sure there are many protections on submodules.