GEOS-DEV / LvArray

Portable HPC Containers (C++)
BSD 3-Clause "New" or "Revised" License
47 stars 10 forks source link

Redid ArrayOfArraysView::setCapacityOfArray to avoid move #307

Closed corbett5 closed 9 months ago

corbett5 commented 9 months ago

Related to https://github.com/GEOS-DEV/GEOS/pull/2870

TotoGaz commented 9 months ago

Thanks for you support @corbett5 !

You can test this PR against gcc-12 which had the testCRSMatrix crashing. Simply remove lines 166 of .github/workflow/ci_tests.yml (BUILD_AND_TEST_CLI_ARGS: --no-run-unit-tests). And you can also remove line 195 (BUILD_AND_TEST_CLI_ARGS: ${{ matrix.BUILD_AND_TEST_CLI_ARGS }}) which becomes useless.