search

GEOS-DEV / LvArray

Portable HPC Containers (C++)
BSD 3-Clause "New" or "Revised" License
47 stars 10 forks source link

Bugfix/fix compiler pragma for clang #317

Closed rrsettgast closed 6 months ago

wrtobin commented 6 months ago

Per the clang documentation, it understands both #pragma GCC and #pragma clang as synonymous:

https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas

So I'm not sure this is necessary, was there a warning/error motivating this?

rrsettgast commented 6 months ago

Per the clang documentation, it understands both #pragma GCC and #pragma clang as synonymous:

https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas

So I'm not sure this is necessary, was there a warning/error motivating this?

Ah. It is because clang didn't recognize the warning flag Walloc-size-larger-than= and I think Wstringop-overflow= as well.