search

GEOS-DEV / thirdPartyLibs

Repository to build the GEOSX third party libraries
3 stars 12 forks source link

add fesapi (RESQML) to CMakeLists #202

Closed untereiner closed 1 year ago

untereiner commented 2 years ago

related to https://github.com/GEOSX/GEOSX/pull/2117

untereiner commented 2 years ago

Hi! First step for RESQML integration: adding the third-parties. Where can I enable the ENABLE_FESAPI flag to the CI to compile it ?

klevzoff commented 2 years ago

Where can I enable the ENABLE_FESAPI flag to the CI to compile it ?

I would suggest just adding an option 

option( ENABLE_FESAPI "" ON )

next to these lines.

I'm ok with this being ON by default, assuming no build issues come up on any of the platforms (LC and TotalEnergies clusters). If they do come up, we'll change the default to OFF and explicitly enable it in default host-config and Travis config

rrsettgast commented 1 year ago

@TotoGaz Even though we disabled trillions, looks like the brew update will lead to running out of time again.

TotoGaz commented 1 year ago

The thing is that I did not find any way to fix the brew issue. And I don't use brew so I can only copy/paste recipes from the web. One solution that I can see is to test using the open-mpi version officially in sync which is 4.1.4 instead of 4.1.1 we have actually?

untereiner commented 1 year ago

Maybe a brew update or update the macOS image ?

TotoGaz commented 1 year ago

Maybe a brew update or update the macOS image ?

If you manage to make it work it's perfect. Or simply don't build it on MacOSX

untereiner commented 1 year ago

The CI is green. I think it is ready to be merged

TotoGaz commented 1 year ago

The CI is green. I think it is ready to be merged

This PR does not seem to build GEOSX?

untereiner commented 1 year ago

@TotoGaz Yet it does !

paveltomin commented 1 year ago

@TotoGaz @rrsettgast should we drop fesapi from tpl since the PR on GEOS side got abandoned?

untereiner commented 1 year ago

Hello @paveltomin, if you don’t use it, don’t compile it.. by the way to make it work a long running update was requested #213