search

GEOS-DEV / thirdPartyLibs

Repository to build the GEOSX third party libraries
3 stars 12 forks source link

Update for Sherlock #256

Closed matteofrigo5 closed 7 months ago

matteofrigo5 commented 8 months ago

Main changes:

  1. Change the INSTALL_DIR_ROOT
  2. Change the DOCKER_ROOT_IMAGE (update to CUDA 11.7.1)

Relates to https://github.com/GEOS-DEV/GEOS/pull/2977

jafranc commented 8 months ago

@matteofrigo5 Are we sure on the final path it will be in ? Or will it be in /oak/stanford/groups/tchelepi ?

matteofrigo5 commented 8 months ago

I've create two distinct directories, namely /oak/stanford/groups/tchelepi/geos-sherlock/CPU and /oak/stanford/groups/tchelepi/geos-sherlock/GPU, to segregate the binaries for the respective deployments of CPU and GPU. @jafranc do you think it might create some problems?

jafranc commented 8 months ago

I've create two distinct directories, namely /oak/stanford/groups/tchelepi/geos-sherlock/CPU and /oak/stanford/groups/tchelepi/geos-sherlock/GPU, to segregate the binaries for the respective deployments of CPU and GPU. @jafranc do you think it might create some problems?

No that's good, then this PR should reflect those choices :) And you're good to merge and deploy

The PR reflect those choices:

https://github.com/GEOS-DEV/thirdPartyLibs/blob/23c14997f41c4c783bbdec27d349a13f23ea67a6/.github/workflows/docker_build_tpls.yml#L45

https://github.com/GEOS-DEV/thirdPartyLibs/blob/23c14997f41c4c783bbdec27d349a13f23ea67a6/.github/workflows/docker_build_tpls.yml#L51

Do I need to edit any other file?

TotoGaz commented 8 months ago

Do I need to edit any other file?

I'd say it's OK! Now it's possible (and probably a good idea 🤣 ) to test before merging!

jafranc commented 8 months ago

I've create two distinct directories, namely /oak/stanford/groups/tchelepi/geos-sherlock/CPU and /oak/stanford/groups/tchelepi/geos-sherlock/GPU, to segregate the binaries for the respective deployments of CPU and GPU. @jafranc do you think it might create some problems?

No that's good, then this PR should reflect those choices :) And you're good to merge and deploy

The PR reflect those choices:

https://github.com/GEOS-DEV/thirdPartyLibs/blob/23c14997f41c4c783bbdec27d349a13f23ea67a6/.github/workflows/docker_build_tpls.yml#L45

https://github.com/GEOS-DEV/thirdPartyLibs/blob/23c14997f41c4c783bbdec27d349a13f23ea67a6/.github/workflows/docker_build_tpls.yml#L51

Do I need to edit any other file?

Not that I recall, @TotoGaz is it the only location even post-GA introduction ?

TotoGaz commented 8 months ago

is it the only location even post-GA introduction ?

The TPLs and geos will be installed in this folder.