search

GEOS-DEV / thirdPartyLibs

Repository to build the GEOSX third party libraries
3 stars 12 forks source link

Add prefix to RAJA build options #283

Open victorapm opened 1 month ago

victorapm commented 1 month ago

Add RAJA_ prefix to CMake build options for RAJA as the current format on master is not being recognized

rrsettgast commented 1 month ago

@victorapm can you create a GEOS PR to test this?

victorapm commented 1 month ago

Yes, I can do that.

I just realized this:

https://github.com/GEOS-DEV/thirdPartyLibs/blob/0aebb1b819da93408bb4c1a781c5bd36c4047899/CMakeLists.txt#L721

which is a couple of years old. Should we update to a newer superlu-dist?

castelletto1 commented 1 month ago

Yes, I can do that.

I just realized this:

https://github.com/GEOS-DEV/thirdPartyLibs/blob/0aebb1b819da93408bb4c1a781c5bd36c4047899/CMakeLists.txt#L721

which is a couple of years old. Should we update to a newer superlu-dist?

Yes, let's update to the latest release

rrsettgast commented 3 weeks ago

@victorapm The update of superLU may be problematic. I suggest you split this PR to just update the raja build options and we do the superlu in another PR