search

GEOS-ESM / ESMA_cmake

Custom CMake macros for the GEOS Earth System Model
Apache License 2.0
4 stars 9 forks source link

Merge Develop into main for release #265

Closed mathomp4 closed 2 years ago

mathomp4 commented 2 years ago

As the title says, this pulls develop into main for a release.

mathomp4 commented 2 years ago

I'm blocking this. I just realized our FindESMF.cmake file assumes that ESMF is still using the old style beta_snapshot style of tags. But @rsdunlapiv, et al, have moved to more semver like beta tags v8.3.0b14. So we should support that before moving into this so ESMF_VERSION returns the right thing!

mathomp4 commented 2 years ago

I'm blocking this. I just realized our FindESMF.cmake file assumes that ESMF is still using the old style beta_snapshot style of tags. But @rsdunlapiv, et al, have moved to more semver like beta tags v8.3.0b14. So we should support that before moving into this so ESMF_VERSION returns the right thing!

Ooh. Actually, I think I need to look at the "official" FindESMF.cmake from ESMF. That seems to have some updates that we don't have. Though I might need to hack around it a bit. We've been assuming the CMake target is esmf not ESMF. Though that might be as simple as:

if (ESMF_FOUND)
  add_library(esmf ALIAS ESMF)
endif ()

and our code keeps working.