search

GEOS-ESM / ESMA_cmake

Custom CMake macros for the GEOS Earth System Model
Apache License 2.0
4 stars 9 forks source link

Update GNU_Fortran.make #292

Closed natalie-perlin closed 1 year ago

natalie-perlin commented 1 year ago

Adding compiler flags for x86_64 architecture and Linux.

Tested for building MAPL/2.22.0 using ESMA_cmake/3.12.0 on Ubuntu22.04 Linux machine with x86_64 architecture.

This PR solves issue Issue#291

mathomp4 commented 1 year ago

@natalie-perlin Could you move the new code until after the Intel section? I'd prefer something like this to be the last possible choice in an if-test.

natalie-perlin commented 1 year ago

Modified as requested. Yes, absolutely, it may need to be the last option, if other conditions not satisfied.

In my test case, it could have been the configuration of Ubuntu running as a virtual machine on MacOS, which caused some mix-up of the expected outcomes/options.

mathomp4 commented 1 year ago

Needs an entry in the ChangeLog.md file.

Ahh. Good call. I've changed the label to be 0-diff as the "trivial" label skips the changelog. But this is a pretty substantive change!

mathomp4 commented 1 year ago

@natalie-perlin Can you make an update to the CHANGELOG.md detailing this PR. That way it can pass our tests.

natalie-perlin commented 1 year ago

@mathomp4 - Updated the Changelog. Please let me know if any modification are needed for the log.

mathomp4 commented 1 year ago

Doing a final check now to make sure this is good when on native Intel (as it should be).