search

GEOS-ESM / ESMA_cmake

Custom CMake macros for the GEOS Earth System Model
Apache License 2.0
4 stars 9 forks source link

Update Intel Fortran Debugging flags #297

Closed mathomp4 closed 1 year ago

mathomp4 commented 1 year ago

Closes #296

This PR adds extra flags to Intel Fortran Debug builds to make them stricter:

mathomp4 commented 1 year ago

Well, nuts. Maybe we can't be this strict for now.

Two of the bad files are ours:

and I could work with @pcolarco (probably?) for the first and @narnold1 for the second.

The last file is in geos-chem, but this is mainly due to the old version we are using. @yantosca fixed those nearly two years ago, we are just well behind. I know @christophkeller wants to move us ahead.

I'll consult with @tclune about how to proceed.

pcolarco commented 1 year ago

Hi Matt-

Don’t follow this but happy to check in with you next week.

Pete

Peter Colarco NASA GSFC Code 614 NASA Goddard Space Flight Center Greenbelt, MD 20771 301.614.6382 (ph) 301.614.5903 (fax)

@.**@.> http://acd-ext.gsfc.nasa.gov/People/Colarco http://www.researcherid.com/rid/D-8637-2012

From: Matthew Thompson @.> Reply-To: GEOS-ESM/ESMA_cmake @.> Date: Tuesday, December 13, 2022 at 10:50 AM To: GEOS-ESM/ESMA_cmake @.> Cc: Peter Colarco @.>, Mention @.***> Subject: [EXTERNAL] Re: [GEOS-ESM/ESMA_cmake] Update Intel Fortran Debugging flags (PR #297)

Well, nuts. Maybe we can't be this strict for now.

Two of the bad files are ours:

and I could work with @pcolarcohttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpcolarco&data=05%7C01%7Cpeter.r.colarco%40nasa.gov%7Cfe0a90be236b44c34f8108dadd2a1ae5%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638065470172010382%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WHE%2Fl6V0LB3u6u31j%2BTWXCgup0WaEtatNU%2FQ%2BWOFEdE%3D&reserved=0 (probably?) for the first and @narnold1https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnarnold1&data=05%7C01%7Cpeter.r.colarco%40nasa.gov%7Cfe0a90be236b44c34f8108dadd2a1ae5%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638065470172010382%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1vBnt2KG7vTw6FIt8vXnZx2PY1vsKJTDtMTJXeIh32g%3D&reserved=0 for the second.

The last file is in geos-chem, but this is mainly due to the old version we are using. @yantoscahttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fyantosca&data=05%7C01%7Cpeter.r.colarco%40nasa.gov%7Cfe0a90be236b44c34f8108dadd2a1ae5%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638065470172010382%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0U0KB2ZjVLYe3FjaT69sKApFjLB3axjOVNr%2B7oVOJuc%3D&reserved=0 fixed those nearly two years ago, we are just well behind. I know @christophkellerhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchristophkeller&data=05%7C01%7Cpeter.r.colarco%40nasa.gov%7Cfe0a90be236b44c34f8108dadd2a1ae5%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638065470172010382%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZU66XWvF7%2FcUFQfhUDf%2BKoK4KkwHE8Eiv6DTMnnPD%2F4%3D&reserved=0 wants to move us ahead.

I'll consult with @tclunehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftclune&data=05%7C01%7Cpeter.r.colarco%40nasa.gov%7Cfe0a90be236b44c34f8108dadd2a1ae5%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638065470172010382%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Tf6KNSnvaLrJ6t4C2UpB0YqWfhSooz5XiOpRnJw7zrs%3D&reserved=0 about how to proceed.

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FESMA_cmake%2Fpull%2F297%23issuecomment-1349047778&data=05%7C01%7Cpeter.r.colarco%40nasa.gov%7Cfe0a90be236b44c34f8108dadd2a1ae5%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638065470172010382%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HphlL%2BAwslP05k3TTB1bhLgjVPNR2rAX%2BcWjtnt8oAo%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANW73YBBCM32HUA3DNJA7FLWNCSMHANCNFSM6AAAAAAS5NCNBU&data=05%7C01%7Cpeter.r.colarco%40nasa.gov%7Cfe0a90be236b44c34f8108dadd2a1ae5%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638065470172010382%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=S7Ve4bcWjGzjoSDqk71YQrbkdx8Falle5a43%2FDY3T4w%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

mathomp4 commented 1 year ago

@pcolarco Actually, it might not be needed right away. Tom and I decided for now to just apply the flags to MAPL. Eventually we might get around to "everywhere" but not right now.

Maybe one day :)