search

GEOS-ESM / ESMA_cmake

Custom CMake macros for the GEOS Earth System Model
Apache License 2.0
4 stars 9 forks source link

Add AMD Milan Support #304

Closed mathomp4 closed 9 months ago

mathomp4 commented 1 year ago

This PR adds support for AMD Milan. Testing at NAS shows that:

elseif (${proc_description} MATCHES "EPYC 7..2")

matches the Romes and that:

elseif (${proc_description} MATCHES "EPYC 7..3")

matches the Milan processors on AWS.

We mainly do this to use -znver3 on AWS.

UPDATE: Turns out tests on the Milans at NCCS show there is no difference between -znver2 and -znver3. Same speed, zero-diff. Thus we do not add complication to ESMA_cmake and close this PR.

github-actions[bot] commented 1 year ago

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

mathomp4 commented 1 year ago

I'm going to block this until I can actually test on Milan. Probably good not to break things. 😄

mathomp4 commented 1 year ago

Well, testing with the Bill Branch shows it crashes with any optimization it seems. znver2, znver3, native...

I'll try stock GEOSgcm...

github-actions[bot] commented 9 months ago

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

github-actions[bot] commented 9 months ago

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

github-actions[bot] commented 9 months ago

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.