search

GEOS-ESM / ESMA_cmake

Custom CMake macros for the GEOS Earth System Model
Apache License 2.0
4 stars 9 forks source link

Test for version of Apple command line utilities to decide whether '-Wl,-ld_classic' is needed #377

Closed climbfuji closed 5 months ago

climbfuji commented 5 months ago

All in the title.

I tested this on my mac with version 14 and it did not apply the flags (which is correct).

mathomp4 commented 5 months ago

I rebased against develop as that is where we put new features (usually). I'll work on testing this on my Macs to make sure it doesn't hurt (not sure how it could but just in case...)

mathomp4 commented 5 months ago

Hmm. And I realize I might have just made the same sin on Baselibs. I guess I'm just used to everyone at NASA being on xcode 15. Well, cross that bridge when I come to it...

mathomp4 commented 5 months ago

I crossed the bridge. Dang. Welp, time to "borrow" your code for Baselibs :)

mathomp4 commented 5 months ago

Actually, you are right, this is a bug on main. My bad...oh but I already screwed it up. Crap. Well, I can fake it. :)

mathomp4 commented 5 months ago

@climbfuji Well, this seems to work for me on my mac (where the flag is needed). So feel free to undraft when you want.

climbfuji commented 5 months ago

Undrafted! I see a few CI errors realted to changelog and PR labels, can you help with that please?

mathomp4 commented 5 months ago

I used superpowers to merge in. Something...weird with github.

climbfuji commented 5 months ago

Thanks @mathomp4 ! Now all we need is a tag for this? and a GEOS PR :-)

mathomp4 commented 5 months ago

Thanks @mathomp4 ! Now all we need is a tag for this? and a GEOS PR :-)

Done:

https://github.com/GEOS-ESM/ESMA_cmake/releases/tag/v3.45.2

and done:

https://github.com/GEOS-ESM/GEOSgcm/pull/784