GEOS-ESM / FVdycoreCubed_GridComp

MAPL/ESMF wrapper for the cubed-sphere finite volume dynamical core
Apache License 2.0
3 stars 10 forks source link

Fixes for FV3 standalone #224

Closed mathomp4 closed 1 year ago

mathomp4 commented 1 year ago

This PR has some minor changes for issue encountered while looking at the FV3 Standalone. The main change is to make some prints at fv_first_run only. Before you got:

 AGCM Date: 1891/03/01  Time: 04:30:00  Throughput(days/day)[Avg Tot Run]:      11024.2      13485.2      13612.8  TimeRemaining(Est) 000:00:06   19.5% :  18.1% Mem Comm:Used
 Running In Adiabatic Mode
 Q
 Q001
 AGCM Date: 1891/03/01  Time: 04:37:30  Throughput(days/day)[Avg Tot Run]:      11072.3      13370.5      13501.3  TimeRemaining(Est) 000:00:06   19.5% :  18.1% Mem Comm:Used
 Running In Adiabatic Mode
 Q
 Q001
 AGCM Date: 1891/03/01  Time: 04:45:00  Throughput(days/day)[Avg Tot Run]:      11120.2      13472.7      13597.2  TimeRemaining(Est) 000:00:06   19.5% :  18.1% Mem Comm:Used
 Running In Adiabatic Mode
 Q
 Q001

where

 Running In Adiabatic Mode
 Q
 Q001

is printed at every time step! Now it looks like:

 AGCM Date: 1891/03/01  Time: 04:30:00  Throughput(days/day)[Avg Tot Run]:      10657.9      13168.5      13293.0  TimeRemaining(Est) 000:00:06   19.7% :  18.6% Mem Comm:Used
 AGCM Date: 1891/03/01  Time: 04:37:30  Throughput(days/day)[Avg Tot Run]:      10708.5      13180.7      13308.9  TimeRemaining(Est) 000:00:06   19.7% :  18.6% Mem Comm:Used
 AGCM Date: 1891/03/01  Time: 04:45:00  Throughput(days/day)[Avg Tot Run]:      10757.5      13163.1      13289.4  TimeRemaining(Est) 000:00:06   19.7% :  18.6% Mem Comm:Used

Much nicer.

mathomp4 commented 1 year ago

I suppose I should mention @pchakraborty to make sure these minor changes wouldn't affect him. They shouldn't, but just in case...

mathomp4 commented 1 year ago

Tested and is zero-diff for the GCM as expected. I see no change even in log output.