search

GEOS-ESM / FVdycoreCubed_GridComp

MAPL/ESMF wrapper for the cubed-sphere finite volume dynamical core
Apache License 2.0
3 stars 10 forks source link

Feature/tclune/#81 compute coords locally #258

Closed tclune closed 10 months ago

tclune commented 10 months ago

Updated fv3.j to include the new control flag for using the new and improved coordinate calculations in dycore.

github-actions[bot] commented 10 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 10 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 10 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 10 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 10 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

mathomp4 commented 10 months ago

I can confirm this along with https://github.com/GEOS-ESM/GFDL_atmos_cubed_sphere/pull/83 is zero-diff.

cc: @wmputman

github-actions[bot] commented 10 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

mathomp4 commented 10 months ago

I had to do a merge here. so I'll do one more test to make sure all is zero-diff.

github-actions[bot] commented 10 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Contingent - DNA, Needs Lead Approval, Skip Changelog

mathomp4 commented 10 months ago

Now that fvdycore geos/v2.7.0 is out, we can release this.