search

GEOS-ESM / FVdycoreCubed_GridComp

MAPL/ESMF wrapper for the cubed-sphere finite volume dynamical core
Apache License 2.0
3 stars 10 forks source link

Backward compatibility import #259

Closed FlorianDeconinck closed 9 months ago

FlorianDeconinck commented 10 months ago

Refactor in the DSL port infrastructure lead to a change of import of the geos_wrapper code. We introduce a backward compatible import to be able to cover both current and next version of the wrapper.

FlorianDeconinck commented 10 months ago

Looks gFTL version issue on the CI, which is unrelated to the PR. Is there a branch I should merge in?

mathomp4 commented 10 months ago

Ohh. Your CI is out of date. You might try updating the .circleci/config.yml to be like that in the mainline:

https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/blob/main/.circleci/config.yml

mathomp4 commented 10 months ago

The issue now seems to be that you are missing some updates from this repo itself. This:

/root/project/GEOSgcm/src/Components/@GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSsuperdyn_GridComp/@FVdycoreCubed_GridComp/StandAlone_FV3_Dycore.F90(18): error #6457: This derived type name has not been declared.   [MAPL_FLAPCLI]
   type (MAPL_FlapCLI) :: cli
---------^

is from old MAPL. We moved to fArgParse back in June:

https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/pull/208