search

GEOS-ESM / GEOS_OceanGridComp

GEOS Ocean Gridded Component
Apache License 2.0
3 stars 2 forks source link

Build time option for ocean model #57

Closed sanAkel closed 7 months ago

sanAkel commented 9 months ago

This PR:

Example: If a user wants to build using MOM5 ocean model, in addition to [these cmake options]() add: -DGEOS_OCEAN=MOM5; defaults are defined in a contingent PR. See ⬇️.

github-actions[bot] commented 9 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

github-actions[bot] commented 9 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

github-actions[bot] commented 9 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

github-actions[bot] commented 7 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

github-actions[bot] commented 7 months ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA

sanAkel commented 7 months ago

There is a dependency on mom6 library in src/Applications/@UMD_Etc/UMD_oletkf/CMakeLists.txt

esma_add_library (${this}
  SRCS ${SRCS}
  DEPENDENCIES **mom6** NetCDF::NetCDF_Fortran MPI::MPI_Fortran
  )

Because of above, one must always build GEOS with mom6, so build of mom5--only is not possible-- FYI: @mathomp4.

For now closing this PR, but noted for future.

mathomp4 commented 7 months ago

There is a dependency on mom6 library in src/Applications/@UMD_Etc/UMD_oletkf/CMakeLists.txt

esma_add_library (${this}
  SRCS ${SRCS}
  DEPENDENCIES **mom6** NetCDF::NetCDF_Fortran MPI::MPI_Fortran
  )

Because of above, one must always build GEOS with mom6, so build of mom5--only is not possible-- FYI: @mathomp4.

For now closing this PR, but noted for future.

Well, if MOM5 is selected, we could just not build UMD_oletkf? If it's needed for mom5 as well, then we'd have to explore more.

sanAkel commented 7 months ago

There is a dependency on mom6 library in src/Applications/@UMD_Etc/UMD_oletkf/CMakeLists.txt

esma_add_library (${this}
  SRCS ${SRCS}
  DEPENDENCIES **mom6** NetCDF::NetCDF_Fortran MPI::MPI_Fortran
  )

Because of above, one must always build GEOS with mom6, so build of mom5--only is not possible-- FYI: @mathomp4. For now closing this PR, but noted for future.

Well, if MOM5 is selected, we could just not build UMD_oletkf? If it's needed for mom5 as well, then we'd have to explore more.

That: not build UMD_oletkf can work, because truth is, nobody is running that UMD_oletkf.

@mathomp4 if you have the time, please do make that switch in UMD_oletkf to turn off its build with mom6. Thank you!

mathomp4 commented 7 months ago

@sanAkel So should I have UMD_oletkf build only with mom5 or only with mom6?

sanAkel commented 7 months ago

@sanAkel So should I have UMD_oletkf build only with mom5 or only with mom6?

@mathomp4 We should not build it at all :) recall, I had a PR to remove it?

Anyway only mom5, that code will never work with mom6.