GEOS-ESM / GEOS_OceanGridComp

GEOS Ocean Gridded Component
Apache License 2.0
3 stars 2 forks source link

Update high-res configuration #65

Closed sanAkel closed 8 months ago

sanAkel commented 8 months ago

This PR:

  1. Gets rid of commented lines.
  2. Turns off known buggy switches.
  3. Turns on VERTEX_SHEAR (requested by @Dooruk and suggested by @travissluka).
  4. Turns off 2018 answers.

Does not impact answers with MOM5 ocean model.

These changes will cause answers to differ (@mathomp4 please note for testing at this resolution; we already have DEFAULT_2018_ANSWERS = False for coarse-res configuration that is used for testing), for the better!

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

Dooruk commented 8 months ago

Thank you @sanAkel for making this update. I see the checkerboard pattern disappear with the new option.

sanAkel commented 8 months ago

Thank you @sanAkel for making this update. I see the checkerboard pattern disappear with the new option.

For sake of bookkeeping, @Dooruk, would you please upload that plot? Showing that pattern disappear? Thanks!

Dooruk commented 8 months ago

For sake of bookkeeping, @Dooruk, would you please upload that plot? Showing that pattern disappear? Thanks!

Sure, top one is without the VERTEX_SHEAR option turned on. Also, thanks @travissluka for finding this issue!

compare

sanAkel commented 8 months ago

Thanks a lot!

Dooruk commented 8 months ago

@sanAkel, The override is missing #override RESTART_CONTROL = 2 which impacts RECORD_FREQUENCY checkpoint dumps. I don't want to create a new issue for it but that is needed either in MOM_input or MOM_override.

Essentially, RECORD_FREQUENCY option is not creating MOM6 checkpoint files properly. MOM6 restarts keep getting overwritten:

Screenshot 2024-02-29 at 2 09 26 PM
sanAkel commented 8 months ago

@sanAkel, The override is missing #override RESTART_CONTROL = 2 which impacts RECORD_FREQUENCY checkpoint dumps. I don't want to create a new issue for it but that is needed either in MOM_input or MOM_override.

Essentially, RECORD_FREQUENCY option is not creating MOM6 checkpoint files properly. MOM6 restarts keep getting overwritten:

Screenshot 2024-02-29 at 2 09 26 PM

@Dooruk will you please add that yourself- in your own version of MOM_override?

I checked previous versions of MOM_input and MOM_override for RESTART_CONTROL, they had default (=1) too. If I recall correct, you either got that =2 from me offline (or from maybe from someone)? Because clearly previous versions (in this repo) did not have anything but default value.

When we run the model (only) without an assimilation or need for it, we do not want restarts piling up- long runs will exhaust the disk space. That's not your case with short runs. We need to create another MOM_override for assimilation, so please gather this and others you might want and we'll make a new config next time. Ok?

Dooruk commented 8 months ago

@Dooruk will you please add that yourself- in your own version of MOM_override?

Yeah, what you say makes sense, all good 👍