search

GEOS-ESM / GEOS_OceanGridComp

GEOS Ocean Gridded Component
Apache License 2.0
3 stars 2 forks source link

Updates to use FMS in Baselibs #69

Closed mathomp4 closed 5 months ago

mathomp4 commented 6 months ago

This is a PR for when GEOS moves to FMS 2024.01. In doing so, we move to FM2 infrastructure rather than ye olde FMS1. (cc @sanAkel)

Note I'm marking this as both zero-diff and non-zero-diff because...it's weird. See https://github.com/GEOS-ESM/GEOSgcm/pull/368 for more info but it's like a couple fields are different, but barely so and it doesn't seem to affect anything else.

mathomp4 commented 5 months ago

@sanAkel Note that I hope we can get this in and tagged soon. So I guess something for you to think on: Should this be Ocean v2.2? Or maybe v3.0?

I mean, the only change is: Now requires new FMS...but that is a big requirement!

sanAkel commented 5 months ago

@sanAkel Note that I hope we can get this in and tagged soon. So I guess something for you to think on: Should this be Ocean v2.2? Or maybe v3.0?

I mean, the only change is: Now requires new FMS...but that is a big requirement!

@mathomp4 I already approved it.

Merge it when you want to.

As for the version number, we can get to that when making a new release (next step For everything else...) for now, go ahead merge this.

While you are at the ocean, can you please update mom6 fork - if outdated. 🙏