search

GEOS-ESM / GEOS_OceanGridComp

GEOS Ocean Gridded Component
Apache License 2.0
3 stars 2 forks source link

v2: Remove DEFAULT_2018_ANSWERS as obsolete #78

Closed mathomp4 closed 2 months ago

mathomp4 commented 2 months ago

This is a v2 PR for #77 which removes DEFAULT_2018_ANSWERS

Closes #77

zhaobin74 commented 2 months ago

Thanks, @mathomp4. It works. @sdrabenh should get this update for his next release.

mathomp4 commented 2 months ago

@zhaobin74 I'll work on getting a new tag out for @sdrabenh tomorrow I hope.

I guess one other question: do you want the latest MOM6? I did merge in https://github.com/mom-ocean/MOM6/pull/1631 into our fork a couple weeks ago but I didn't make a release.

But since, well, you are the main Ocean dev at this time I suppose, if you like, I can make one and then promote it up the chain. I would be non-zero-diff unless a couple things are set, see https://github.com/mom-ocean/MOM6/pull/1631#issuecomment-2252914251

zhaobin74 commented 2 months ago

@mathomp4, thanks for keeping our fork of MOM6 up to date. Over the long term, I think, it is always beneficial to keep running with the latest version, especially if there is bug fix or new feature needed. For now, we can update MOM6 with those 2 new options to be zero-diff. I am fine with it.

mathomp4 commented 2 months ago

@mathomp4, thanks for keeping our fork of MOM6 up to date. Over the long term, I think, it is always beneficial to keep running with the latest version, especially if there is bug fix or new feature needed. For now, we can update MOM6 with those 2 new options to be zero-diff. I am fine with it.

@zhaobin74 Sooooo...how would one do that? I mean, I sort of figured something out so I could give @marshallward a thumbs up, but I'm sure I did it in a very heavy-handed manner. What would be the "right" way in GEOS land? Would I/we add lines to the MOM_override files? Or MOM_input?

zhaobin74 commented 2 months ago

@mathomp4, thanks for keeping our fork of MOM6 up to date. Over the long term, I think, it is always beneficial to keep running with the latest version, especially if there is bug fix or new feature needed. For now, we can update MOM6 with those 2 new options to be zero-diff. I am fine with it.

@zhaobin74 Sooooo...how would one do that? I mean, I sort of figured something out so I could give @marshallward a thumbs up, but I'm sure I did it in a very heavy-handed manner. What would be the "right" way in GEOS land? Would I/we add lines to the MOM_override files? Or MOM_input?

Yes, we can add them in MOM_override. So an OceanGridComp update needs go along with MOM6.

mathomp4 commented 2 months ago

Yes, we can add them in MOM_override. So an OceanGridComp update needs go along with MOM6.

Okay. I might work with you Monday on that to make sure I do it right.

mathomp4 commented 2 months ago

This PR in combination with #81 and with MOM6 geos/v3.2 is zero-diff to current MOM6.