search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Modify 'id_ship' test to include BUFR ship subtypes #107

Closed gmao-msienkie closed 2 years ago

gmao-msienkie commented 2 years ago

I noticed earlier this week that Santha's 'id_ship' test had not been updated to include the new BUFR ship subtypes. We have been looking at some problems with ship PS and it could be useful to distinguish these from the other kx=180 types in the GSI I edited the change on Github and had a stupid branch name. When I changed the name the prior pull request was closed.

gmao-msienkie commented 2 years ago

In order to use 'id_ship' the prepobs_errtable.global needs to be updated to fill in obs error for kx=198/298. I copied the errors from kx=180/280 to 198/298 and saved a copy of the file in the feature/msienkie/bufr-id_ship_update branch in the GEOSadas repository.

gmao-msienkie commented 2 years ago

This will not change results unless id_ship is set to 'true'. As a side note - the original code only changes the ship mass obs kx from 180 to 198, the ship wind obs do not have their KX modified. If we wanted to separate ship winds from other marine types there would need to be an additional modification of the code.