search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Delete unneeded call to closbf #113

Closed gmao-msienkie closed 2 years ago

gmao-msienkie commented 2 years ago

The "closbf" call used to be needed because there was an "openbf" call earlier in the program. Between CVS v1.26.2.1 and v1.26.2.2 that "openbf" call was removed but the (now unneeded) "closbf" call was not removed. It isn't a problem with the static allocation BUFR lib but it caused a problem when the BUFR lib was compiled with DYNAMIC allocation.

The code may or may not be a problem with a later version of the BUFR library, I haven't tested. However this call to closbf is clearly not needed anymore. Let's just get rid of this call.

gmao-msienkie commented 2 years ago

I checked the code and there are more questionable subroutines than I want to check so I am closing this and deleting the request. I think that at least some (hopefully all) of these will be taken care of in a future NCEP release.