search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Correct geopotential_height outputs in NetCDF diag files. #122

Closed gmao-jjin3 closed 1 year ago

gmao-jjin3 commented 1 year ago

Correct geopotential_height outputs by not to add surface geopotential heights upon them. Save geopotential height for all observational types in setupw.f90.

github-actions[bot] commented 1 year ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

github-actions[bot] commented 1 year ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

rtodling commented 1 year ago

JJ: I had approve this earlier - did you just add more to the same branch?

gmao-jjin3 commented 1 year ago

Thanks. @rtodling . No that is all for this PR. There is another PR I closed before but brought it back since now we do plan to use correct GSI adjusted observation errors for some JEDI tests: https://github.com/GEOS-ESM/GEOSana_GridComp/pull/118