search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Feature/wgu/crtm2.4.0+i rbugfix #125

Closed gmao-wgu closed 1 year ago

gmao-wgu commented 1 year ago

This PR was created to introduce the minor bug fixes to IR from the NCEP including the updated surface temperature check in qcmod.f90 and some tweaks to the selection of clear scenes during thinning for AIRS, IASI and CrIS-FSR. For CriS-FSR, the bufr reading was also updated to be consistent with CRTM 2.4.0. crtm_interface.f90 was updated to handle the allsky assimilation of AMSR2,MHS and GMI under CRTM 2..4.0. gamo_global_satinfo.rc was also updated to go with the reconfigured cloud detection for CrIS-FSR and the reconfigured gross-check for IR.

github-actions[bot] commented 1 year ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

github-actions[bot] commented 1 year ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement

gmao-wgu commented 1 year ago

Why are you changing the iuse flags in the satinfo file? This changes more than just the IR? Is this because you want all channels to be monitored? Did you make sure this change is zero diff as you expect?

As far as I knew, all the changes should be in IR to reflect the reconfigured cloud detection for CrIS-Fsr and the reconfigured gross-check for IR. I will take a look when I get to home tonight.

gmao-wgu commented 1 year ago

Another issue is the obs error covariance wired to Wei's location. This needs to be unwired.

Is the R cov changing because there are new channels being used for IR?

I am sorry I did not get it. The only thing I could think of that was pointing to my directory is the CRTM data files in analyzer.

gmao-wgu commented 1 year ago

@rtodling I checked the files changed(totally 9 files), I could not see the issues you mentioned except the one: comments like "yzhu" should be removed in the code.