search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Skip identical conventional observations. #126

Closed gmao-jjin3 closed 1 year ago

gmao-jjin3 commented 1 year ago

A few minor changes in order to make inflated observational errors of conventional observations identical to those values in GEOS. (1) Keep only one of those conventional observations which are made at the same locations, level, and time, and discard the rest of them. As a result, we can avoid losing those data in IODA converter, and have same duplicate factors in JEDI as in GSI. (2) Determine duplicate factors by single precision geo-location values since single precision values are saved in NC_Diag files and then used in JEDI/UFO. (3) Not to consider sensible temperature and virtual temperature made at same locations as duplicated observations. (4) Save observation types (kx) of duplicated observations in NC_Diag files.

github-actions[bot] commented 1 year ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

gmao-jjin3 commented 1 year ago

@rtodling I saw your email yesterday and I tend to withdraw these changes. They are merely for UFO configuration. I don't know exactly how significant their impact in GSI. We probably don't want add these changes in GSI if the impact is significant. If the impact is insignificant, on the other hand, those differences in inflated errors between GSI and UFO should have insignificant impact in JEDI results too. @danholdaway how do you think?

rtodling commented 1 year ago

I commented the prints in the setup's here related to the duplicate obs ... too many of them.

gmao-jjin3 commented 1 year ago

I commented the prints in the setup's here related to the duplicate obs ... too many of them.

No problem at all.