GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

PR 130 introduced a bug - fixed now #134

Closed rtodling closed 1 year ago

rtodling commented 1 year ago

The changes introduced here:

https://github.com/GEOS-ESM/GEOSana_GridComp/pull/130/files

left the zges variable undefined unless the following condition was satisfied.

if ((itype>=223 .and. itype<=228) .or. sfc_data) then

From what I see zges should be defined as what the code calls zges_read unless the condition above is met, in which case the values of zges would be redefined as within the "if' statement.

Since w/o this fix the code will crash under certain conditions - interestingly the default mode of running GSI does not seem to crash, but other modes do - this change is being labeled as non-zero-diff.