search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Skip "Forecast_adjusted" in radiance ncdiag files #136

Closed gmao-jjin3 closed 1 year ago

gmao-jjin3 commented 1 year ago

The variable "Forecast_adjusted" is removed from NC_diag files in order to avoid confusion and error in IODA converter, because it is not correct for some radiance data such CRIS-FSR. It should be "sngl(tb_obs(ich_diag(i))-tbc0(ich_diag(i)))". Corrected "Forecast_adjusted" can be derived from the two variabless "Observation" and "Obs_Minus_Forecast_adjusted".

gmao-yzhu commented 1 year ago

This code change looks fine to me.

From: Jianjun Jin @.> Reply-To: GEOS-ESM/GEOSana_GridComp @.> Date: Sunday, June 25, 2023 at 10:48 PM To: GEOS-ESM/GEOSana_GridComp @.> Cc: "Zhu, Yanqiu (GSFC-6101)" @.>, Review requested @.***> Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/GEOSana_GridComp] Skip "Forecast_adjusted" in radiance ncdiag files (PR #136)

CAUTION: This email originated from outside of NASA. Please take care when clicking links or opening attachments. Use the "Report Message" button to report suspicious messages to the NASA SOC.

@gmao-jjin3https://github.com/gmao-jjin3 requested your review on: #136https://github.com/GEOS-ESM/GEOSana_GridComp/pull/136 Skip "Forecast_adjusted" in radiance ncdiag files.

— Reply to this email directly, view it on GitHubhttps://github.com/GEOS-ESM/GEOSana_GridComp/pull/136#event-9632451586, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARUMEBSZWGKOWXW6NDYHRSDXNDZ63ANCNFSM6AAAAAAZTRB6TA. You are receiving this because your review was requested.Message ID: @.***>

gmao-jjin3 commented 1 year ago

Does it really hurt to keep this in the diag file?

No, it doesn't. We are able to get around it in IODA converter now.